Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency symbols #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashwinkey04
Copy link
Contributor

Fixes #125

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@laxyapahuja
Copy link

You'll have to fetch the corresponding currency symbol from the API. It's not going to $ every time.

@ashwinkey04
Copy link
Contributor Author

You'll have to fetch the corresponding currency symbol from the API. It's not going to $ every time.

On it ;)

@ashwinkey04 ashwinkey04 reopened this Jan 28, 2020
@garvit984
Copy link
Collaborator

@ashwinkey04 The currency has to be fetched with the help of API calls and not hardcoded. So can we please close this PR?

@ashwinkey04
Copy link
Contributor Author

Can you provide me some inputs on fetching the currency symbol using the API? So that I can make necessary changes and submit my PR

@garvit984
Copy link
Collaborator

@ashwinkey04 You can have a look at this documentation https://demo.mifos.io/api-docs/apiLive.htm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add currency symbol
3 participants